Fix forcedeps mode with build numbers#42
Merged
ChrisRackauckas merged 1 commit intojulia-actions:mainfrom Mar 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DLR-AMR/T8code.jl#109, I noticed a small problem with the forcedeps mode, when JLL packages are involved because they often have build numbers
+xin their version number. Since the compat bounds in Project.toml do not include the build number, but the resolved version does the exact comparison of the two fails, but we only want to test for major, minor, and patch version. Should be fixed by this PR.Can you take a quick look please, @ChrisRackauckas?